Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring model so we could avoid shortcoming of linkml model #257

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

yarikoptic
Copy link
Member

Shortcoming in question:

AFAIK this should result in no changes necessary to metadata records since none of those "features" was used. So even though we break the model, I think we could just go with "patch" level progress forward.

Individual commits have more information.

TODOs also

  • do something about genotype "Identifier" being abused to encapsulate records describing the genotype, hence better be parsed etc ??? file a separate issue.

since Any also represents List or anything else really.
I thought that it might be used somewhere in the meditor to edit dandiset metadata
but it seems that nothing of that type propagated into dandiset metadata so
it should not be effected

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "git-sedi 'Union\\[Any, List\\[Any\\]\\]' Any",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
…s) for Locus and Allele

So far I see no values with such data types used at all in dandi archive so we should not
break anything

An alternative would be to just make it a List[Identifier] always and not
bother allowing for the dance of singular-vs-plural.
That would avoid Union of a list with non-multivalued identifier. And we already have
data with string value describing the genotype -- it is not really an identifier!!!
@yarikoptic yarikoptic added the patch Increment the patch version when merged label Oct 31, 2024
@yarikoptic
Copy link
Member Author

@candleindark please review test fails and what needs to be done to make it green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants